DRIVERS-3081: Relax requirement for optional fields and introducing appName for failPoints for transactions unified tests #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you open a DRIVERS ticket for this change and link it here? |
sanych-sun
changed the title
ShaneHarvey
reviewed
Jan 9, 2025
| @@ -572,6 +573,7 @@ tests: | |||
| - isMaster | |||
| - hello | |||
| closeConnection: true | |||
| appName: *appName | |||
There was a problem hiding this comment.
I think these transaction test changes look good. I believe we couldn't use this feature originally because of this server bug: SERVER-49336. Can you confirm that these tests pass on current 4.2 and up servers?
There was a problem hiding this comment.
Yes, the tests are green.
There was a problem hiding this comment.
There are 2 possible fixes for now: use appName with additional connection for failPoints OR simply wait for all failPoints to be processed and then remove fialPoint (the second approach makes us waste around of 3-4 seconds waiting)
|
I'm testing this in Python here: mongodb/mongo-python-driver#2058 Will report back on the status. |
ShaneHarvey
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While migrating to unified spec format for transactions tests in CSHARP Driver I've run into 2 minor problems which I suggest to fix by this PR (please let me know if the changes makes sense and I'll create an appropriate ticket):
findOneAndModifycommand optional ({ $$unsetOrMatches: false })hellocommand, I suggest to use appName to let other connection work (we use additional client to setup and tire down the failpoints).